search

roughike / BottomBar

(Deprecated) A custom view component that mimics the new Material Design Bottom Navigation pattern.
Apache License 2.0
8.43k stars 1.51k forks source link

Not support set badge count in text format #856

Open itman85 opened 6 years ago

itman85 commented 6 years ago

I currently cannot set badge count in text format. In case number is large such as 150,200... i want to display badge number as "99+". But there is method set badge with integer only.

leonardo2204 commented 6 years ago

The problem with this approach is that some logic is performed behind the badge count (like hiding or showing if greater or less than 0), so I'm not sure how the app should behave when having String values. IMO, I'd agree implementing something like TextView's ellipse (using a threshold), like, if count > x show '+' sign. What do you think @itman85 and @roughike ? I'd gladly drop a PR !

itman85 commented 6 years ago

That's awesome if support a threshold to show plus sign and setting text size

leonardo2204 commented 6 years ago

@itman85 PR #859 created. Now we wait :)