search

rougier / bootstrap-rst

Restructured Text Bootstrap
MIT License
20 stars 4 forks source link

Rendering is wrong for some pages #38

Open rougier opened 6 years ago

rougier commented 6 years ago

After @akuroiwa PR merging, some page display is weird (components.html, getting-started.html). Probably some page template is wrong relatively to new bootstrap.

akuroiwa commented 6 years ago

I'm very sorry. I guess that there are differences between Bootstrap v3.1.1 and v3.3.7. To make matters worse, I appended v4.

rougier commented 6 years ago

No problem. But some pages render ok and some other not. Do you have any idea what could be the reason ?

akuroiwa commented 6 years ago

I tried quick-fix solution:

cd test/
rst2bootstrap3 --stylesheet="https://maxcdn.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.min.css" ~/src/bootstrap-rst/doc/components.rst components.html

It works. Drastic measure is:

  1. Delete the contents of bootstrap/ directory.
  2. Copy Bootstrap v3.1.1 files.
  3. Put the v4.0.0-beta.2 of bootstrap/css/carousel.css and bootstrap/js/holder.min.js back into the directory.
  4. Edit STYLESHEET of Makefile and stylesheet_path of bootstrap.traditional_main().

If you prefer BootstrapCDN URL to local files, please skip the second step.

rougier commented 6 years ago

Can you make a PR for that? What is the difference between Bootstrap and BootstrapCDN?

akuroiwa commented 6 years ago

I will try. It will take a few days.

Since I don't know the difference, I will delete local files. If you have any problems, please add them after that.