search

rougier / elegant-emacs

A very minimal but elegant emacs (I think)
GNU General Public License v3.0
1.36k stars 79 forks source link

fixes for Melpa #15

Closed NicoloZorzetto closed 3 years ago

NicoloZorzetto commented 3 years ago

Hello, these are the fixes they asked. I had to remove the setting of the font and they asked about some sets implying a theme shouldn't do that. I think we can get away with it but if they really won't let us I'm afraid we'll need to make a minor mode that sets the modeline etc and color themes to set the colors.

Again, I think we can get away with it but time will tell.

NicoloZorzetto commented 3 years ago

They also asked for a GitHub compatible license:

Add a LICENSE file that GitHub can detect (e.g. no markup) if possible See: https://github.com/licensee/licensee

NicoloZorzetto commented 3 years ago

I changed the names like you suggested, how are we going to do the copyright thing?

rougier commented 3 years ago

Hum, I cannot merge because of conflicts but GitHub is not very helpful.

NicoloZorzetto commented 3 years ago

It is in conflict because I renamed the files and it’s detecting them as deleted. Do you prefer I add the old ones so you can merge and then delete them?

rougier commented 3 years ago

Well, I cannot merge nor resolve from the GitHub interface, weird. I'll give a try from terminal

rougier commented 3 years ago

It worked.

NicoloZorzetto commented 3 years ago

Nice! Now only thing remaining is the copyright. Should I look into that?

rougier commented 3 years ago

Oh yes. Also, we can get rid of sanity.el and elegance.el

rougier commented 3 years ago

By license, you mean adding the GPL3 in the repo ?

NicoloZorzetto commented 3 years ago

They asked for this:

Add a LICENSE file that GitHub can detect (e.g. no markup) if possible See: https://github.com/licensee/licensee

rougier commented 3 years ago

Just added LICENSE.txt to the repo.

rougier commented 3 years ago

And made some adjustements to the layout (underline descent and header line right part alignment)

NicoloZorzetto commented 3 years ago

Perfect! I'll let them know

NicoloZorzetto commented 3 years ago

They seem to like the recipe although I initially forgot to change the name of the files.

I was wondering: do you want to change the name of the package itself since we changed that of the files? I know we said to keep it so people could find it easily but maybe creating another repo redirecting to the one with the proper name could help. The guy who's following our pull request has hinted to a change of name but I don't think it'll be a problem if you decide to keep elegant-emacs.

There is also the possibility of creating a minor mode but I don't know if we'd have to change the files completely or just ship elegance.el and the themes (without the requirement for the minor mode) separately, if you want I can look into that

rougier commented 3 years ago

What is the current name and that would be the alternative ? I've no strong opinion if the choice is between elegant and elegance and elegant-emacs.

NicoloZorzetto commented 3 years ago

Yep, I was thinking about those. I like elegant-emacs but I also get why someone would think it's strange to include the name emacs in that of the package.

What about the minor mode? What do you think?

rougier commented 3 years ago

Re-reading your question about the name: you seem to imply that changing the name would require a new repo ? Concerning the minor mode, I'm not sure to see any advantage of having a minor mode, but I may miss something obvious.

NicoloZorzetto commented 3 years ago

Re-reading your question about the name: you seem to imply that changing the name would require a new repo ? Concerning the minor mode, I'm not sure to see any advantage of having a minor mode, but I may miss something obvious.

Yea I was thinking of a new repo because people who know your work will search for 'elegant-emacs' and changing the name of this repo would give them no results.

I don't think having a minor mode would have many 'benefits' but I worry people at Melpa will complain seeing that a theme is changing not just the colors.

Your work is peculiar and the 'theme' section might not comprehend everything it's done here.

NicoloZorzetto commented 3 years ago

I really like the visuals of this approach, but the elegant.el file is not really a package, and is more akin to a starter kit or a very wide set of hard-coded user preferences, given that it toggles all sorts of minor modes. This is typically not the sort of thing we host. The file appears to serve partly as a tool for defining the two themes (which are the sort of thing we happily host!) but it all works by using a large number of unprefixed top-level functions and variables instead of the proper custom-theme-set-faces and custom-theme-set-variables facilities, so they are not really standard Emacs themes at all. In summary, the current state of this is that it is a very interesting visual experiment, but not ready for wider distribution as a package.

This is the last comment they left. As I worried looking into it they saw the use of top level functions and the lack of custom-theme-set-variable.

I don't know how to proceed, they even ruled out the possibility of a minor mode.

rougier commented 3 years ago

😞 That's hard. Maybe we should start a starter kit project instead. I've recenty performed some experiments with nano emacs that share a lot to thing with elegant emacs and we could try to unify them. I fear this means more work but maybe it's worth. What do you think ?

terlar commented 3 years ago

Perhaps it could be worth reaching out to @hlissner and the doom emacs community. Feels like maybe there could be interest there and joining forces could provide a lot of community, expertise and reach. Just a wild suggestion :)

I might also be interested, but I am short on time for the near future.

rougier commented 3 years ago

In the meantime, we could use quelpa and put it forward in the readme (I did that for https://github.com/rougier/svg-tag-mode)