search

rougier / elegant-emacs

A very minimal but elegant emacs (I think)
GNU General Public License v3.0
1.36k stars 79 forks source link

Org mode table content is difficult to read #16

Open mtbakerguy opened 3 years ago

mtbakerguy commented 3 years ago

Thanks for the elegant theme as it's amazing. Between the font, color scheme, and minimal startup, it's brilliant. I have noticed one readability problem--the content of org mode tables is difficult to see.

mtbakerguy commented 3 years ago

Forgot to mention that this is in the dark theme.

mtbakerguy commented 3 years ago

I went ahead and changed the following to make the text easier to read:

(set-face-attribute 'face-faded nil :foreground "#7777a7" :weight 'light)

Change the color from #777767 to #7777a7.

rougier commented 3 years ago

Thanks! Could you post a screen shot before after ?

mtbakerguy commented 3 years ago

image before

image after

terlar commented 3 years ago

Perhaps the issue is that table body is using the faded face.

rougier commented 3 years ago

I guess it would be better to use the default face for the table column marker. Do you know the name of the face? (is there a dedicated one?)

terlar commented 3 years ago

I don't think there is a face for the table column marker, there is the face is org-table which I think is used by both markers and table content.

BTW, slightly unrelated, but might find interesting, you can "prettify" tables via the https://github.com/casouri/valign That already has logic for the structural elements, perhaps an issue could be opened to add a face as well, then they could also be styled differently.

rougier commented 3 years ago

Thanks for the link, great package. I need to study it further but it might be really useful for alignment in the header line. I've checked the org-table and you're right, there's only one face so maybe it would be better to use the default face instead of faded. I would be nicer to have a separate face for border but this would require hacking org-mode I guess.

rougier commented 3 years ago

Can you make a PR with default face?