search

rougier / freetype-gl

OpenGL text using one vertex buffer, one texture and FreeType
Other
1.65k stars 266 forks source link

Android Support for Freetype-GL #109

Closed ignitusboyone closed 6 years ago

ignitusboyone commented 8 years ago

I've patched in a few explicit linker commands when compiling for Android the NDK. The NDK has horrible LINK debugging so I would rather hard link to the compression deps then assume the person using the resulting libs knows they are required. I also added support for the creation of a dynamic lib. I find them useful when working on Linux.

I use your project for several Qt based OpenGL applications and these patches are being pushed upstream to simplify the modifications I make when building my Android variants. I can make any additional changes if you do not link the linker dep lines.

rougier commented 8 years ago

Nice, thanks. It seems Travis has failed, can you investigate ?

adrianbroher commented 8 years ago

Please don't merge with upstream. Rebase instead.

ignitusboyone commented 8 years ago

I didn't realize CI failed. I'll review the feedback and re-base. Are you sure you would rather require two build configurations instead of maybe gating the Shared and Static libs with cached bools?

rougier commented 8 years ago

Thanks, now Travis seems to be happy. @adrianbroher any comment before merge ?

adrianbroher commented 8 years ago

@adrianbroher any comment before merge ?

Yes, never merge pull requests that contain a master -> topic merge commit. I experienced great troubles with this in other projects.

@ignitusboyone please clean up the commit by rebasing as I asked you months ago.

Also you didn't address my comment on the static/shared build.

rougier commented 8 years ago

Good catch, did not see it.

ignitusboyone commented 6 years ago

Updating this commit request after neglecting it for years.