search

rougier / freetype-gl

OpenGL text using one vertex buffer, one texture and FreeType
Other
1.65k stars 266 forks source link

atb-agg demo fixes for retina displays #140

Open yairchu opened 7 years ago

yairchu commented 7 years ago

The atb-agg demo looks like this on my MacBook Pro (Retina, 13-inch, Late 2012):

screen shot 2016-12-20 at 2 01 46 pm

And the atb widgets do not respond to the mouse at their displayed locations.

This change fixes these issues.

rougier commented 7 years ago

Thanks. Actually, I think all the demos get the same problem on mac book pro retina. I opened issue #91 some time ago but I've never found the time to make a proper fix. Do you have an idea how we could factorize your fix ?

yairchu commented 7 years ago

For #91, I believe that the different demos will require different changes (as we don't want them all to be really tiny on high density displays right?), and this PR partially fixes the problem (does it for atb-agg).

bagobor commented 7 years ago

include ?

On Dec 22, 2016 11:01, "Yair Chuchem" notifications@github.com wrote:

@yairchu commented on this pull request.

In demos/atb-agg.c https://github.com/rougier/freetype-gl/pull/140:

@@ -423,6 +423,18 @@ void TW_CALL get_tertiary( void value, void data ) // ------------------------------------------------------------------- init --- void init( GLFWwindow* window ) {

  • int is_scaled;
  • {
  • int pixWidth, pixHeight, winWidth, winHeight;
  • glfwGetFramebufferSize( window, &pixWidth, &pixHeight );
  • glfwGetWindowSize( window, &winWidth, &winHeight );
  • is_scaled = pixWidth > winWidth || pixHeight > winHeight;

If is_scaled is defined as bool, I get the following compilation error:

demos/atb-agg.c:433:5: error: use of undeclared identifier 'bool' bool is_scaled; ^

I'm used to using bool in C++, but afaik it isn't available in plain C, which I haven't used in quite a while, so I'm not sure what to use.. What do you suggest?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rougier/freetype-gl/pull/140, or mute the thread https://github.com/notifications/unsubscribe-auth/AArOi6M72V8MwEHh8qQGDhvufzcHVQbNks5rKkqFgaJpZM4LRw9o .

yairchu commented 7 years ago

Fixed, thanks.

yairchu commented 7 years ago

@bagobor does it look ok now?