search

rougier / freetype-gl

OpenGL text using one vertex buffer, one texture and FreeType
Other
1.65k stars 266 forks source link

remove "rise" field from markup_t #145

Closed yairchu closed 7 years ago

yairchu commented 7 years ago

There's no support for it since f83aae3389b5ddaab56342a050828591baeb9899, so it may just cause confusion and mislead.

rougier commented 7 years ago

I'm lost. Why did it disappear ? and what the relation with f83aae3389b5ddaab56342a050828591baeb9899 ?

yairchu commented 7 years ago

It appears that for 5 years, since https://github.com/rougier/freetype-gl/commit/f83aae3389b5ddaab56342a050828591baeb9899, there is no support for the rise field. There are assignments to it, but it is never read. The comment for it says that it's for something but it just does nothing.. So I guess it is either a bug that this field isn't actually supported or that it should be removed (because it can be misleading as is).

rougier commented 7 years ago

Got it, thanks.