rougier / freetype-gl

OpenGL text using one vertex buffer, one texture and FreeType
Other
1.65k stars 266 forks source link

add missing static keyword to internal function file_exists #146

Closed yairchu closed 7 years ago

yairchu commented 7 years ago

The file_exists function in font-manager.c isn't marked static, even though it is internal to that file and does not have a prefixed name, so it can easily clash with other functions of the same name. Not only it can clash but reportedly when creating Haskell bindings for freetype-gl it indeed does clash with a function of the same name from ghc's Win32Utils.

I didn't find other such functions with are not exposed in the header file or their names are unprefixed which aren't static - this appears to be the only one.

rougier commented 7 years ago

Thanks