search

rougier / freetype-gl

OpenGL text using one vertex buffer, one texture and FreeType
Other
1.65k stars 266 forks source link

Remove calls to glBlendColor which do nothing #150

Closed yairchu closed 3 years ago

yairchu commented 7 years ago

glBlendColor only has an effect when using glBlendFunc with GL_CONSTANT_COLOR, GL_ONE_MINUS_CONSTANT_COLOR, GL_CONSTANT_ALPHA, or GL_ONE_MINUS_CONSTANT_ALPHA. (according to https://www.opengl.org/sdk/docs/man4/html/glBlendFunc.xhtml).

As these blend funcs aren't used anywhere, the calls to glBlendColor are misleading, and someone looking to learn from these examples might end up quite confused.

aqilc commented 3 years ago

@rougier do you want to look at it? A lot of old pull requests are just sitting around, and some of them look useful, like this one.

rougier commented 3 years ago

Yes, it might be tome to close old issue. Concerning this specific one, I remember adding them for a reason but maybe it was used only during experiments. Can you conform this does not change output?

yairchu commented 3 years ago

I verified when making the change, and did also re-verify now too after merging with current master, and it works the same. (not I didn't re-verify the markup demo which doesn't build on my M1 Mac seems due to using Intel fontconfig)

rougier commented 3 years ago

Thanks.