search

rougier / freetype-py

Python binding for the freetype library
Other
298 stars 88 forks source link

Remove redundant wheel dep from pyproject.toml #168

Closed mgorny closed 1 year ago

mgorny commented 1 year ago

Remove the redundant wheel dependency, as it is added by the backend automatically. Listing it explicitly in the documentation was a historical mistake and has been fixed since, see: https://github.com/pypa/setuptools/commit/f7d30a9529378cf69054b5176249e5457aaf640a

rougier commented 1 year ago

Seems the build failed.

anthrotype commented 1 year ago

I think this PR needs to be rebased on master because it also needs this https://github.com/rougier/freetype-py/pull/167

mgorny commented 1 year ago

Honestly, this failure makes no sense. Lemme try locally, perhaps cibuildwheel is broken (sigh).

mgorny commented 1 year ago

Ok, now I see what the problem is. If FREETYPEPY_BUNDLE_FT is set, setup.py imports wheel directly. This also happens when setup.py is run to get build-time dependencies, so we're dealing with a circular dep — setup.py needs wheel to be able to say that it needs wheel.

The wheel dep is incorrect for the general case but needed when FREETYPEPY_BUNDLE_FT is set.