search

rougier / from-python-to-numpy

An open-access book on numpy vectorization techniques, Nicolas P. Rougier, 2017
http://www.labri.fr/perso/nrougier/from-python-to-numpy
Other
2.06k stars 340 forks source link

Idiomatic English #106

Open vartsos opened 2 years ago

vartsos commented 2 years ago

Hi as I am a French speaker, and a native English speaker (British). The following phrasing from chapter 3.4 “As a conclusion, we'll make an exercise. Given…” should read “In conclusion, we will complete the following excercise: Given …” so in French it is normal to use faire (to make), in English for this context complete.” Also as a conclusion, is translated in conclusion. If these comments are useful I will continue to provide feedback as I read through the text. Thanks Greg.

rougier commented 2 years ago

Thanks. As a native French speaker, my English is not so good :) Could you make a PR?

vartsos commented 2 years ago

Absolutely, I love what you have done and will proof read :) For the help that you have provided to the community.

On Mon, 11 Jul 2022 at 12:20, Nicolas P. Rougier @.***> wrote:

Thanks. As a native French speaker, my English is not so good :) Could you make a PR?

— Reply to this email directly, view it on GitHub https://github.com/rougier/from-python-to-numpy/issues/106#issuecomment-1180271266, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASRQ5NTQFS7F2OA27JQSBDVTP7QZANCNFSM53FER63Q . You are receiving this because you authored the thread.Message ID: @.***>