Typo in Section 7.1 Back to Python

rougier / from-python-to-numpy

An open-access book on numpy vectorization techniques, Nicolas P. Rougier, 2017

http://www.labri.fr/perso/nrougier/from-python-to-numpy

Other

2.03k stars 339 forks source link

Typo in Section 7.1 Back to Python #72

Closed jessicayung closed 5 years ago

jessicayung commented 6 years ago

In the paragraph after the code for solution_1 in Section 7.1, 11641 should be 14641:

This solution is the slowest solution because it requires 4 loops, and more importantly, it tests all the different combinations (11641) -> (14641) of 4 integers between 0 and 10 to retain only combinations whose sum is 10. We can of course get rid of the 4 loops using itertools, but the code remains slow:

Thanks!

rougier commented 6 years ago

Thanks ! Can you make a PR (such that your name appears in the contributors) ?

jessicayung commented 6 years ago

Cool, just made a PR.

kyscg commented 5 years ago

Close this since it is fixed? @jessicayung @rougier