rougier / from-python-to-numpy

An open-access book on numpy vectorization techniques, Nicolas P. Rougier, 2017
http://www.labri.fr/perso/nrougier/from-python-to-numpy
Other
2.03k stars 339 forks source link

Jupyter-book version #95

Open lhoupert opened 3 years ago

lhoupert commented 3 years ago

Hi, Just to let you know that I forked this repository, to work on a jupyter-book version [here]

It is currently a work in progress, I encountered an issue with the TOC referencing when building the jupyter book. All the pages are built but the main TOC only reference the first two pages.

However, you can have an idea of a potential redesign of the book by visiting this temporary repository here. Screenshot 2020-07-15 at 12 02 53

Let me know if you think it is a useful thing to do or not. I am learning how to use jupyter-book and I wanted to read this book so I thought I could try to do both at the same time :-). If you think this is not necessary to have a jupyter-book version, I am happy to delete the branch.

Let me know your thoughts!

rougier commented 3 years ago

That's really great and I think a lot of people (including me) will be very happy to have this jupyter book. For the TOC, I'm not sure to be able to help you since I'm not too familiar with Jupyter book. I don't remember having done anything special with the TOC and I don't know what could be the problem.

lhoupert commented 3 years ago

Great! It seems to be a bug with jupyter-book. I just opened an issue about it here.

I will be away until mid August, but will work on it when I am back. Once solved, it should be relatively straightforward to build and publish once the each time the *rst files are modified. The only thing maybe would be to adapt the landing page file.

Once the bug is fixed, I can send a pull request for a new branch and we can see from there?

lhoupert commented 3 years ago

@rougier The issue on the toc nased on .rst files has been solved with this PR https://github.com/executablebooks/jupyter-book/pull/1293 . Building a jupyter-book from .rst files is now quite straigthforward. I opened a PR here https://github.com/rougier/from-python-to-numpy/pull/104