search

rougier / mu4e-dashboard

A dashboard for mu4e (mu for emacs)
GNU General Public License v3.0
467 stars 43 forks source link

Melpa package #46

Open ghost opened 2 years ago

ghost commented 2 years ago

Would it be possible to package mu4e-dashboard as a melpa package?

rougier commented 2 years ago

Yes, but I need to check the procedure.

ghost commented 1 year ago

Is there any way I can help with this?

rougier commented 1 year ago

Sorry for delay. If you have any pointer on the procedure and what needs to be done, that would be great.

jmszro commented 11 months ago

@rougier, the MELPA package submission procedure can be found here. In short, you need to fork the MELPA repo, add a recipe for the package, then submit a pull request.

rougier commented 10 months ago

I'm trying to fix the pacakge before submission but I'm stuck with the make check because of the async dependency. I'm not familiar with the Emacs Lisp Regression Testing and I'm not sure how to specify load path for async (and other packages). Any idea?

jmszro commented 10 months ago

Here is how the Helm maintainer has solved this problem (lines 36 through 61). Locate the elpa/straight directory, find the async installation within that directory, add it to a LOAD_PATH variable (along with other paths that should be added to that variable, like the current directory), then load LOAD_PATH with emacs using the -L option wherever emacs is called.

rougier commented 10 months ago

Thanks. I've one warning left: mu4e-dashboard.el:198:16: Warning: Unused lexical variable `mu4e-headers-results-limit'. Not sure how to get rid of it though.

jmszro commented 10 months ago

I believe this is because the (local) variable mu4e-headers-results-limit is not used within the let expression in which it is bound (line 198 of mu4e-dashboard.el) . I think this is a bug - I might be wrong, but I don't think you can temporarily change the value of a global variable within a let expression.

Incidentally, that variable has been marked as obsolete in the most recent mu release. The preferred alias of the variable is mu4e-search-results-limit.

progfolio commented 10 months ago

I might be wrong, but I don't think you can temporarily change the value of a global variable within a let expression.

You are incorrect. let-binding special variables is common practice. To quell the byte-compiler (ignore mu4e-headers-results-limit) can be added in the body of the let form.

jmszro commented 10 months ago

Oops, sorry for the inaccuracy.

rougier commented 9 months ago

Done (no more lint warning). Need now to proceed with Melpa submission.

magandrez commented 1 month ago

@rougier Is this still up?

In order to have reproducible builds and installs of Emacs, having a package distributed over MELPA would be lovely.