search

rougier / mu4e-dashboard

A dashboard for mu4e (mu for emacs)
GNU General Public License v3.0
467 stars 43 forks source link

I think this read-only test is backwards #51

Open rhstanton opened 7 months ago

rhstanton commented 7 months ago

In mu4e-dashboard-update, we find the following code:

        (if buffer-read-only
            (mu4e-dashboard-update-all-async)
          (error "Dashboard cannot be updated only in read-only mode"))))))

Shouldn't the two options be reversed?

rhstanton commented 7 months ago

Actually, I'm not sure any more, since the error message is a bit ambiguous:

"Dashboard cannot be updated only in read-only mode"

It should probably either say "can" instead of "cannot", or else the word "only" should not be there.

Right now, if I turn off read-only mode and press "U" I get the error message above, and in read-only mode, when I press "U" it does not go off and read new email as I was expecting (like "U" does at the original mu4e screen). Am I missing something here?

Many thanks for a nice interface to mu4e.

rougier commented 6 months ago

Thank for the report. This is a mistake. The actual message shoudl be "Dashboard can only be updated in read-only mode". Do you want to make a PR?