search

rougier / mu4e-dashboard

A dashboard for mu4e (mu for emacs)
GNU General Public License v3.0
467 stars 43 forks source link

don’t use obsolete org function #6

Closed omar-polo closed 3 years ago

omar-polo commented 3 years ago

org-add-link-type was marked as deprecated with Org 9.0 (sometime before 2016-08), this patch switches to the suggested replacement, org-link-set-parameters.

stsquad commented 3 years ago

As I just raised in #7 the link type should be changes as well (maybe mu4edb:) so it doesn't clash with the exiting packages mu4e-org support.

omar-polo commented 3 years ago

Uh, you're right, the link type should change. I've changed the link type (locally -- not pushed yet) to mu4edb (FWIW i like the name, it's shorter than, say, mu4e-dashboard). I'm not sure, but I fear that such change would conflict with #4, so better wait until it's merged.

I could re-purpose this PR to "change link type" if you prefer, or just close it and let you and @rougier solve the link type issue.

rougier commented 3 years ago

Thanks. I've looked at org-mu4e but I did not find the link definition. But if e need to change the name, can't we use mu?

omar-polo commented 3 years ago

Here's the updated PR so, with the change from mu4e -> mu.

While there I also noticed that there was a typo, In one of the link to a saved query for the mail from Stallman, the link was [[mu4e:mu4e:from:rms@gnu.org||100][100]], the updated patch fixes also this.

omar-polo commented 3 years ago

Nicolas P. Rougier notifications@github.com writes:

@rougier commented on this pull request.

@@ -53,7 +53,7 @@

(defun mu4e-dashboard-follow-mu4e-link (path)

Do we rename this one too then ? mu4e-dashboard-follow-mu-link

Good catch! I forgot it, apologise.

by the way, do you think that also the various instances of “mu4e link” in the docstrings should be changed to “mu link”s? (e.g. the docstring of mu4e-dashboard-follow-mu-link)

sp1ff commented 3 years ago

I didn't notice this PR before I submitted my own addressing the same issue, albeit in a different way. If everyone's OK just settling on "mu", and breaking existing dashboards, I'm happy to drop mine, but can I suggest that we define a constant for it, rather than repeating the literal "mu"?

omar-polo commented 3 years ago

Yeah, the title is an historical accident :)

I don't know if it makes sense to provide a defcustom for a org link type name, but otherwise I agree that repeating everywhere "mu" isn't a good idea. Anyway, I think it's better to close this, as it went past its initial scope, and eventually continue the discussion in your PR.