search

rougier / mu4e-thread-folding

Functions for folding threads in mu4e headers view
GNU General Public License v3.0
136 stars 12 forks source link

Don't clobber custom face attributes #11

Closed phil-s closed 3 years ago

phil-s commented 3 years ago

Calling set-face-attribute at load time clobbers whatever custom faces the user had configured.

Defaults should always be set as part of the defface.

Note that during development you can use C-M-x within the defface form to re-evaluate and set the value from that definition. This "overrides any customizations of the face, so that it becomes defined exactly as the `defface' expression says".

phil-s commented 3 years ago

n.b. Comments within a defface form seem to prevent things from being defined properly, so I removed them. If you want them to be kept, I think they'll have to go either before or after the property list.

rougier commented 3 years ago

Thanks. The reason I separated def/set is exactly this. Didn't know about the C-M-x.