search

rougier / nano-emacs

GNU Emacs / N Λ N O - Emacs made simple
GNU General Public License v3.0
2.5k stars 191 forks source link

Fix for broken nano-help #111

Open brongulus opened 2 years ago

brongulus commented 2 years ago

Added a fix for quick-help.org not being found when using straight. Fixes the issue #110

rougier commented 2 years ago

Thanks! Given the relative small size of the help, maybe it would be better to store it in a variable inside the source. What do you think?

brongulus commented 2 years ago

That's very reasonable and I should've done that. Pushed a fix, hope it's fine now.

rougier commented 2 years ago

Thanks. I don't see the fix, did you push it?

brongulus commented 2 years ago

I removed the need for extra variable altogether, now it directly looks in the correct directory, without modifying the load-path at all. Hope that's acceptable!

rougier commented 2 years ago

Sorry, I was saying to have the whole help string inside but maybe it's a bad idea in the end. Concerning your fix, I'm afraid it is a bit specific to the install method or is it the common place to search for files?

brongulus commented 2 years ago

It's a common place for straight users but you raise a valid point about this not working out for people who use other methods, since it's not a valid fix, I'll close the PR for now and think about incorporating other methods of installation in the future if possible. Apologies for the inconvenience.

rougier commented 2 years ago

Sorry for the late answer and no need to apology. The issue is still valid since the help doesn't work as expected depending on the installation. This needs to be fixed. I'll reopen the issue to remember it needs to be fixed.