search

rougier / nano-emacs

GNU Emacs / N Λ N O - Emacs made simple
GNU General Public License v3.0
2.54k stars 195 forks source link

Bug: nano interferes with web-mode (TSX) #122

Open hermann-p opened 2 years ago

hermann-p commented 2 years ago

When switching to web-mode, it breaks with Error (prog-mode-hook): Error running hook "highlight-indent-guides-mode" because: (wrong-number-of-arguments #<subr quote> 0) and stays in fundamental mode.

Reproduce:

Let me know if I can help debugging, but remember my elisp-fu is near to non-existent.

rougier commented 2 years ago

Could you try to use nano-modeline instead (which is on ELPA)?

hermann-p commented 2 years ago

Not sure what you mean? Instead of what?

rougier commented 2 years ago

Sorry for not being clear. There is now a dedicated package (nano-modeline) that is available on ELPA. You can install it from Emacs and then test is by typing M-x: nano-modeline (from a "regular" Emacs session, not nano).

hermann-p commented 2 years ago

I got that part, just was confused about the "instead" part. So just the modeline instead of the whole nano package.

Works just fine. Works also if I load the modeline before opening the file.

rougier commented 2 years ago

Sorry for late answer. Does that mean it is working properly now?

hermann-p commented 2 years ago

It means I can run nano-modeline, but still not nano in web-mode. Should I try updating nano-emacs? I don't see any recent commits, though.

rougier commented 2 years ago

I need to update nano-emacs to reflect the change but the story is that I split it in independent packages (nano-theme and nano-modeline) such that people are free to use this or that part. In the meantime, I've also developped several packages that go along the idea of nano emacs. You can have a look at my configuration here: https://github.com/rougier/dotemacs

hermann-p commented 2 years ago

Thank you for your time, and please don't feel pushed. I am aware of the other packages, and I mostly use doom emacs with nano-theme.

On a side note: I feel like the decluttering of colours together with the font hints removes a lot of distraction while still adding visual structure. It helps to focus on complex source code, so, great work!

rougier commented 2 years ago

Thanks. Coming back to your problem, does that mean that nano-theme + nano-modeline works as expected now?

nhunzaker commented 1 year ago

I was able to resolve the issue by commenting out this line: https://github.com/rougier/nano-emacs/blob/c313957b5945e197c7d9cab1115190a339ee856c/nano-defaults.el#L57

rougier commented 1 year ago

Oh, that's surprising and I wonder how you found the problem. Do you want to make a PR (to just comment it by default) ?

nhunzaker commented 1 year ago

Oh, that's surprising and I wonder how you found the problem.

When it stopped working, I just started poking around with the settings to see how all of this actually worked and suspected this might be a font locking issue.

Oh, that's surprising and I wonder how you found the problem.

Sure thing!

rougier commented 1 year ago

Do you want to make a PR?