search

rougier / nano-emacs

GNU Emacs / N Λ N O - Emacs made simple
GNU General Public License v3.0
2.54k stars 195 forks source link

error "Invalid face" bookmark-menu-heading #127

Open philipsd6 opened 2 years ago

philipsd6 commented 2 years ago

When executing find-file in emacs 29.0.50, if you TAB to complete a few times, the error is thrown:

error "Invalid face" bookmark-menu-heading

The bookmark-menu-heading face was removed recently:

commit 021ae515f912d941f0c41d2c6d3c8d322ac9e584
Author: Stefan Kangas <stefankangas@gmail.com> 
Date:   Fri Aug 19 18:24:42 2022 +0200

    * lisp/bookmark.el (bookmark-menu-heading): Delete face.

For those of us using recent versions of emacs, a quick fix is:

sed -i '/bookmark-menu-heading/d' /path/to/nano-emacs/nano-theme.el

For the long run, I guess this setting should have a version guard?

rougier commented 1 year ago

Thanks. I think the nano-theme should handle this case but I'm not quite sure how to integrate with nano-emacs that do not require any installation.

mandarvaze commented 1 year ago

@philipsd6 which path do I run the sed command from ?

philipsd6 commented 1 year ago

It depends on where you install it; for me, I'm using straight, so my command is:

sed -i '/bookmark-menu-heading/d' ~/.emacs.d/straight/repos/nano-emacs/nano-theme.el
mandarvaze commented 1 year ago

Thanks @philipsd6 It worked!

cnngimenez commented 1 year ago

Hi! I added a check on set-face before setting the face. This is the commit on my repository.

This check just message a warning when the face does not exists, in this case, bookmark-menu-heading. Maybe, this is not the solution, but it may be useful for future versions.

Is this useful? Should I do a Pull- Request?

Ah! Is this the same issue as Issue #135 ?

rougier commented 1 year ago

Same issue and your fix is nice actually. If you can make a PR that would be great.