search

rougier / nano-emacs

GNU Emacs / N Λ N O - Emacs made simple
GNU General Public License v3.0
2.5k stars 191 forks source link

Check if a face does not exists before setting it. #146

Closed cnngimenez closed 1 year ago

cnngimenez commented 1 year ago

Hi! When using find-file in Emacs 29, an error message appears: error "Invalid face" bookmark-menu-heading This were reported at Issue #127 ( link ).

As I commented there, I added a check on set-face before setting the face. It just message a warning when the face does not exists, in this case, bookmark-menu-heading. Thus, the library is loaded completely despite not finding the face.

Maybe, this is not the solution, but it may be useful for future versions, particularly, when new faces are modified.

yaqubroli commented 1 year ago

Would be nice if this PR is accepted; currently using Emacs 29 in order to get easy SVG support on Ventura (and thus use Rougier's other great plugin, svg-tag-mode)

rougier commented 1 year ago

Thanks. This will solve a lot of issues. Other option is to use nano-theme which is a proper theme (on ELPA).