search

rougier / nano-emacs

GNU Emacs / N Λ N O - Emacs made simple
GNU General Public License v3.0
2.58k stars 196 forks source link

No bookmark-menu-heading in Emacs 29.0.91 #147

Open tuhdo opened 1 year ago

tuhdo commented 1 year ago

Here is the stack trace:

Debugger entered--Lisp error: (error "Invalid face" bookmark-menu-heading)
  set-face-attribute(bookmark-menu-heading nil :foreground unspecified :background unspecified :family unspecified :slant unspecified :weight unspecified :height unspecified :underline unspecified :overline unspecified :box unspecified :inherit nano-face-strong)
  set-face(bookmark-menu-heading nano-face-strong)
  #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_4>()
  eval-after-load-helper("f:/emacs/share/emacs/29.0.91/lisp/bookmark.elc")
  do-after-load-evaluation("f:/emacs/share/emacs/29.0.91/lisp/bookmark.elc")
  require(bookmark)
  eval-expression((require 'bookmark) nil nil 127)
  funcall-interactively(eval-expression (require 'bookmark) nil nil 127)
  command-execute(eval-expression)
rougier commented 1 year ago

Can you try to add (require 'bookmark)?

tuhdo commented 1 year ago

(require 'bookmark) produced the same error:

Debugger entered--Lisp error: (error "Invalid face" bookmark-menu-heading)
  set-face-attribute(bookmark-menu-heading nil :foreground unspecified :background unspecified :family unspecified :slant unspecified :weight unspecified :height unspecified :underline unspecified :overline unspecified :box unspecified :inherit nano-face-strong)
  set-face(bookmark-menu-heading nano-face-strong)
  #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_4>()
  eval-after-load-helper("f:/emacs/share/emacs/29.0.91/lisp/bookmark.elc")
  do-after-load-evaluation("f:/emacs/share/emacs/29.0.91/lisp/bookmark.elc")
  require(bookmark)
  eval-expression((require 'bookmark) nil nil 127)
  funcall-interactively(eval-expression (require 'bookmark) nil nil 127)
  command-execute(eval-expression)

I loaded bookmark just before (use-package nano). Without loading bookmark, then there's no error but as soon as I tried to use any bookmark commands, Emacs throws that error.

rougier commented 1 year ago

Can you try with latest version? think bookmark has been fixed.

tuhdo commented 1 year ago

@rougier it didn't solve the problem. In the end, I made a workaround by defining the face so NANO won't complain.

Anyway, I finally can integrate NANO with my config and make it look as intended on Windows, which I did not succeed in previous attempts. I made a thread on Reddit if you are curious on how it looks like: https://www.reddit.com/r/emacs/comments/17m8vwq/guide_setup_nano_emacs_theme_properly_on_windows/

Thanks for this great piece of software that really improves my user experience with Emacs.