rougier / nano-emacs

GNU Emacs / N Λ N O - Emacs made simple
GNU General Public License v3.0
2.52k stars 195 forks source link

Additional requirements: ivy / counsel #22

Closed duianto closed 3 years ago

duianto commented 3 years ago

The readme requirements, state that only Emacs and fonts are required: https://github.com/rougier/nano-emacs#requirements

You need a recent version of GNU Emacs and to have the Roboto Mono and Fira Code fonts installed on your system. There are no other dependencies.

After downloading the repository ZIP. Extracting it and running:

runemacs -q -l nano.el

It first complained about the font:

frame-notice-user-settings: Font ‘Roboto Mono:style=Light:size=14’ is not defined

(understandable since the font wasn't installed)

After installing the Roboto Mono font: https://fonts.google.com/specimen/Roboto+Mono and restarting Emacs with nano.el.

Issue:

Now it says:

eval-buffer: Symbol’s function definition is void: ivy-mode

Source:

https://github.com/rougier/nano-emacs/blob/77b81d0c07abe2b0b18c9004eb7b8f2209b9e508/nano-counsel.el#L41

And pressing: M-x shows:

command-execute: Wrong type argument: commandp, counsel-M-x

https://github.com/rougier/nano-emacs/blob/77b81d0c07abe2b0b18c9004eb7b8f2209b9e508/nano-counsel.el#L34

A possible solution

Maybe the nano-counsel requirement should be commented out by default. https://github.com/rougier/nano-emacs/blob/709710127cbefb2e3d3ea774a3b0658e75d3edab/nano.el#L69-L71

Since it disables M-x.

System:

rougier commented 3 years ago

Thanks. You're right, we can comment it out. Can you make a PR?