search

rougier / nano-emacs

GNU Emacs / N Λ N O - Emacs made simple
GNU General Public License v3.0
2.51k stars 194 forks source link

Having nano-emacs around breaks building other modules #84

Open DamienCassou opened 3 years ago

DamienCassou commented 3 years ago

There are 2 problems in nano-emacs code base that breaks my borg-based setup:

  1. nano-defaults.el has top-level instructions with side effect: e.g., (setq-default shell-file-name "/bin/zsh"). This means that loading the file changes Emacs. I suggest wrapping these changes in a nano-defaults function.
  2. nano-defaults.el mixes general-purpose improvements and user-specific configuration (e.g., your email address, name and favorite shell). I suggest moving your configuration to a dedicated file outside of this repository.

My actual problem is that batch compiling my Emacs packages loads nano-defaults.el which changes the default shell to /bin/zsh (which I don't have) and this breaks compiling a subsequent Emacs package.

rougier commented 3 years ago

Thanks for the report. I'm now trying to clean things up by splitting packages into individual repositories (nano-theme, modeline and splash so far) and I need to separate the actual layout from other settings.

DamienCassou commented 3 years ago

That's an excellent idea, thank you!!

By the way, thank you for your talk with https://inacheve-dimprimer.net/. That was inspiring and I'm trying to cleanup my Emacs!