search

rougier / nano-modeline

GNU Emacs / N Λ N O Modeline
GNU General Public License v3.0
175 stars 31 forks source link

Fix funcall nano-modeline-user-mode #17

Closed hans-d closed 2 years ago

hans-d commented 2 years ago

Fixes #16

hans-d commented 2 years ago

in progress: https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html

rougier commented 2 years ago

Thanks. Di you gzt you copyright assignment ?

hans-d commented 2 years ago

Signed contract has been submitted (waiting for final confirmation by FSF), all current PR's have already been earmarked for the assignment

hans-d commented 2 years ago

assignment (past & future) completed

rougier commented 2 years ago

Thanks, I've merged. But then I wonder if we need to have two separate functions:

nano-modeline-user-mode-p: To tell nano-modeline whether to use user-provided modeline. nano-modeline-user-mode: The actual user mode-line

As it is currently, I think you cannot mix nano-modeline with user-modeline. Or did I miss something?

hans-d commented 2 years ago

nano-modeline-user-mode-p is not directly needed, but does fit better with the overal structure already present - and may be less compute intensive in cases where complex functionality is used. The function should do some checking on what mode it is to return the correct mode-line, eg via a cond form.