search

rougier / nano-modeline

GNU Emacs / N Λ N O Modeline
GNU General Public License v3.0
175 stars 31 forks source link

spacer elements in modeline should also get a face #23

Closed hans-d closed 1 year ago

nawetimebomb commented 2 years ago

Great fix, thanks! image

rougier commented 2 years ago

Spacing elements are defined by the active/inactive face no? I failed to see the difference in the screenshot.

rougier commented 2 years ago

Can you rebase your PR?

hans-d commented 2 years ago

rebased / squashed

rougier commented 2 years ago

Thanks. Only one comment on right-margin-width.

hans-d commented 2 years ago

i've noticed that one is needed, as some trailing odd background is visible. (I have a right-margin-width > 0)

rougier commented 2 years ago

I was suggesting right-margin-width -> (or right-margin-width 0)