search

rougier / nano-modeline

GNU Emacs / N Λ N O Modeline
GNU General Public License v3.0
170 stars 29 forks source link

Part of transient buffers are hidden #37

Closed DamienCassou closed 2 years ago

DamienCassou commented 2 years ago

When using Magit, I don't see the commands on the last line:

2022-04-22-200628

rougier commented 2 years ago

What should be displayed exactly? Is it a specific magit mode (for which we could write a specific modeline)?

DamienCassou commented 2 years ago

What should be displayed exactly?

as you can see in the screenshot above, the last line is partially hidden. We should clearly see "k Remove P Prune stale refspecs"

Is it a specific magit mode (for which we could write a specific modeline)?

magit is not to blame here. The problem is with the transient library that is used by magit to create popups. To reproduce:

(defun my/remove ()
  (interactive)
  (message "my/remove"))

(transient-define-prefix my/foo ()
  "documentation"
  ["Group 1"
   ("k" "remove" my/remove)])

and then M-x my/foo:

2022-04-23-100544

Again, the last line is invisible. With emacs -Q, it looks like this instead:

2022-04-23-101046

I think I will discuss the issue in the transient project because transient--show hides the mode-line and the tab-line but not the header-line. Hiding it as well fixes my issue.

DamienCassou commented 2 years ago

Here is the transient issue I opened: https://github.com/magit/transient/pull/198.

DamienCassou commented 2 years ago

My PR got merged so we can close this issue.