search

rougier / nano-modeline

GNU Emacs / N Λ N O Modeline
GNU General Public License v3.0
170 stars 29 forks source link

fringe inconsitancy ! #42

Closed vijaypanchalr3 closed 1 year ago

vijaypanchalr3 commented 2 years ago

Screenshot from 2022-07-06 16-33-15

rougier commented 2 years ago

I think the problem is here where right part is aligned with right margin. Can you comment out (-1 . right-margin) and check if it solved the problem?

Problem is that I don't remember why I added this right margin alignment.

aaronjensen commented 2 years ago

I currently don't have that in my fork:

(propertize " " 'face face-modeline 'display `(space :align-to (- right ,right-len)))

That's all I have and this is what it looks like with window margins:

CleanShot 2022-07-11 at 11 10 43@2x

My line numbers do align to the window margin, but the gray style goes all the way to the end. That could be a face difference though... hard to diagnose this from just a screenshot.

rougier commented 2 years ago

Can you give a try to github version? Else, you can have a look at https://www.gnu.org/software/emacs/manual/html_node/elisp/Pixel-Specification.html and tweak the calculation.

aaronjensen commented 2 years ago

master looks right to me

CleanShot 2022-07-11 at 19 16 18@2x
aaronjensen commented 2 years ago

I updated mine. There's still a difference w/ the right-len, I don't know why what the significance of (- right-len 0) is and putting right-len in its stead seems to work just fine for me.

rougier commented 2 years ago

the (- right-len 0) is probably a left over when I was debugging it. It's probably unnecessary.

rougier commented 1 year ago

It has been fixed in the new simpler branch.