search

rougier / nano-modeline

GNU Emacs / N Λ N O Modeline
GNU General Public License v3.0
170 stars 29 forks source link

respect `(column-number-mode nil)` #48

Closed tonijarjour closed 1 year ago

tonijarjour commented 1 year ago

I apologize if this code is bad. I barely know any elisp.

rougier commented 1 year ago

Well, actually your code is good, thanks! Since nano-modeline is on elpa, could you sign the copyright form. It is not strictly necessary since your change is small but if you contribute further, it will be needed.

tonijarjour commented 1 year ago

Sure but I have to ask if this is seriously ready to merge. There are many other instances of %l%c that might need to be changed. I made this PR to gauge your interest in adding it.

rougier commented 1 year ago

We could merge it as it is but after looking at default mode-line I realized there is also a line-number-mode and for completion, we could enforce it as well. I'm not quite sure how the code from default mode line though.

tonijarjour commented 1 year ago

Does this look reasonable?

rougier commented 1 year ago

Yes. It would be worth to mention it in the readme such that people know how to have previous default behavior.

tonijarjour commented 1 year ago

I filled out the copyright form.

rougier commented 1 year ago

Sorry for the delay.