search

rougier / nano-modeline

GNU Emacs / N Λ N O Modeline
GNU General Public License v3.0
170 stars 29 forks source link

Remove style from box #68

Closed larstvei closed 8 months ago

larstvei commented 8 months ago

Fixes #67.

I am not sure if this is the best permanent solution, as I don't what was the original intention of setting :style to none. I think this should preserve the same behavior, and work with the latest version of Emacs as well.

aaronjensen commented 8 months ago

None may have been intended to be flat-button

rougier commented 8 months ago

Thanks for the fix. If you don't mind I would prefer to use :style nil just to make it explicit we want flat box.

rougier commented 8 months ago

Just merged PR by @aaronjensen which does the same thing with flat-button

larstvei commented 8 months ago

Of course, I can make the change. I would like to suggest using flat-button, making it even more explicit?

rougier commented 8 months ago

I messed up with the PR merge, I think yours is not necessary anymore.

larstvei commented 8 months ago

Don't worry, I completely agree with it being the better solution!