search

rougier / nano-theme

GNU Emacs / N Λ N O Theme
GNU General Public License v3.0
358 stars 35 forks source link

[emacs 28.0.90] Issue with nano-subtle or nano-faded when text highlighted in macOS #17

Closed maikol-solis closed 2 years ago

maikol-solis commented 2 years ago

Hi!

I installed this build (https://github.com/jimeh/emacs-builds/releases/tag/Emacs.2021-12-05.e3427fa.emacs-28) of emacs 28.0.90 (pretest)

When I highlight some text withnano-subtle or nano-faded faces, the foreground text become completely black.

This is how it looks, the #+STARTUP line in some org file:

image

I'm using doom-emacs with this simple configuration 

(use-package! nano-theme
  :config
  (nano-dark))

I guess that the foreground and background should be inverted to keep the contrast.

PS: In emacs 27.2 I haven't had this behavior. Everything looked fine.

Best.

maikol-solis commented 2 years ago

I found the solution.

It's just to add this line in a custom-set-faces

 '(region ((t :distant-foreground nil)))

Thanks.

rougier commented 2 years ago

Thanks for the report and the fix. Can you make a PR?

maikol-solis commented 2 years ago

I did it. Please let me know if I put the fix in the right place.

Thanks.