search

rougier / nano-theme

GNU Emacs / N Λ N O Theme
GNU General Public License v3.0
358 stars 35 forks source link

`Error` (`nano-critical`) face has some display issues #20

Closed maikol-solis closed 2 years ago

maikol-solis commented 2 years ago

Hi!

I'm using nano-theme (nano-dark) with doom-emacs and I found a glitch in org-mode/org-agenda.

When I use priority [#A] in a heading, the foreground of the letter or icon should be yellow with dark background.

However, if I put the cursor above the heading, the foreground turns black with the same dark background.

This is the behavior in org-mode

https://user-images.githubusercontent.com/4078489/150639911-c6f06440-fd8d-41cf-98e0-3d30a625d99f.mov

in org-agenda

https://user-images.githubusercontent.com/4078489/150640168-8a1439f4-d6a3-4ae8-a71a-086bb386f3f0.mov

The face that I found related to this is error (https://github.com/rougier/nano-theme/blob/master/nano-theme.el#L695), inherited by nano-critical(https://github.com/rougier/nano-theme/blob/master/nano-theme.el#L630).

For the moment I couldn't find how to fix this.

I hope you can give some lights about it.

Thanks.

rougier commented 2 years ago

I've just changed the nano-critical face to be a bit less agressive. It is now bold and red (but no bakground). Hopefully it'll solve your problem.

maikol-solis commented 2 years ago

It works perfectly. Thanks! image