search

rougier / nano-theme

GNU Emacs / N Λ N O Theme
GNU General Public License v3.0
376 stars 35 forks source link

magit-diff-whitespace-warning is invisible #28

Open luispauloml opened 2 years ago

luispauloml commented 2 years ago

magit-diff-whitespace-warning is set to nano-default which makes it invisible against the background in which it is intended to appear.

magit-diff-whitespace-warning

rougier commented 2 years ago

Thanks for the report. We could use 'nano-faded' or 'highlight' instead, what do you think?

luispauloml commented 2 years ago

Several magit-diff faces and magit-section-highlight, which are the backgrounds on which magit-diff-whitespace-warning appears, already inherit from highlight, thus this change would render it invisible again.

https://github.com/rougier/nano-theme/blob/06d7c949f876e07a6fa6edc132fba21e1aaba62d/nano-theme.el#L1332-L1342

As for nano-faded, it wouldn't work because it does not change the background, so it would have to be nano-faded-i. The result looks good on nano-dark, but I think it is too dark for nano-light, which is the one I use:

nano-faded-i

If it would change to nano-faded-i, I would still keep using trailing-whitespace in nano-light.

In fact, I liked the result for both themes, as seen in opening of this issue, so removing customization of magit-diff-whitespace-warning from nano-theme in order for it to keep being trailing-whitespace is my suggestion for both themes

rougier commented 2 years ago

Thanks. I've pushed a fix (using nano-subtle)