rougier / nano-theme

GNU Emacs / N Λ N O Theme
GNU General Public License v3.0
376 stars 35 forks source link

Org-table use nano-dark-faded which makes reading difficult in nano-dark #35

Open arael opened 2 years ago

arael commented 2 years ago

The tables in nano-dark are too difficult to read. Is there any way to decouple the nano-dark-faded from org-table colors?

table

rougier commented 2 years ago

What is the face used ? We would modify this face specifically in the theme.

arael commented 2 years ago

The face is called 'org-table'. Every field in 'unspecified' except 'inherit' which is set to 'nano-faded'.

arael commented 2 years ago

May I bother you also for 'italic'? Just like 'org-table' it is difficult to read. All the fields are set to 'unspecified' except 'inherit' which is 'nano-faded'.

Thank you very much!

arael commented 2 years ago

Fixed with custom-set-face function like this:

(use-package nano-theme
    :ensure t
    :config
    (custom-set-faces
        '(italic ((t (:inherit nano-salient))))
        '(org-table ((t (:inherit nano-default)))))
  )
  (load-theme 'nano-dark t)
rougier commented 2 years ago

Thanks. Could you post a screenshot before/after?

arael commented 2 years ago

Sure.

This is before: before

And this is after: after

rougier commented 2 years ago

Perfect, thanks. Can you make a PR?