search

rougier / nano-theme

GNU Emacs / N Λ N O Theme
GNU General Public License v3.0
358 stars 35 forks source link

Ido missing applied themes #36

Open scottlindeman opened 1 year ago

scottlindeman commented 1 year ago

Hello!

In the nano-emacs project, ido-mode is properly themed. However in this new nano-theme project those lines are missing form the custom-theme-set-faces input and we are left with the default red and green foreground text.

The following was in nano-emacs:

(defun nano-theme--ido ()
  "Derive ido faces from nano faces."
  (with-eval-after-load 'ido
    (set-face 'ido-first-match                       'nano-face-salient)
    (set-face 'ido-only-match                          'nano-face-faded)
    (set-face 'ido-subdir                             'nano-face-strong)))

Unless there are any changes you'd like to see, I can make a PR that applies those faces.

Great theme by the way!

rougier commented 1 year ago

Many thanks! Could you make a PR after having signed the copyright assignment (not needed if you already signed it)?