search

rougier / nano-theme

GNU Emacs / N Λ N O Theme
GNU General Public License v3.0
376 stars 35 forks source link

Adding ido faces to nano-theme based off of nano-emacs #37

Open scottlindeman opened 2 years ago

scottlindeman commented 2 years ago

Adding theme support for Ido. https://github.com/rougier/nano-theme/issues/36

Based off of emacs-nano

https://github.com/rougier/nano-emacs/blob/185894da71aeab33e52a1bedcde6cea4b148436c/nano-theme.el

For a diff hiding whitespace (my emacs config deletes any trailing whitespace): https://github.com/rougier/nano-theme/pull/37/files?w=1

rougier commented 2 years ago

Perfect (I just suggested a PR in your issue). Did you signed the copyright assignment?

scottlindeman commented 2 years ago

Just sent out the email to the FSF. Might take a few days to get the paperwork all taken care of!

phikal commented 2 years ago

The copyright assignment probably isn't even necessary for this commit. More so if we disregard the unrelated whitespace changes (that ought to be part of a separate change set. @rougier have you considered adding a .dir-locals.el file to regular whitespace issues?).

rougier commented 2 years ago

@phikal What is .dir-local.el? @scottlindeman There are some conflicts, can you check

phikal commented 2 years ago

@rougier It is a file that Emacs uses to check for directory local variables. E.g. I usually have this

;;; Directory Local Variables
;;; For more information see (info "(emacs) Directory Variables")

((emacs-lisp-mode
  (show-trailing-whitespace . t)
  (indent-tabs-mode . nil)))

That way spaces are always used for indentation, and trailing whitespace is highlighted, for all Emacs users.

rougier commented 2 years ago

Oh, good to know, thanks. Can you make a PR?