Weird mode-line colors with nano-light

maikol-solis commented 9 months ago

Hi!

Today I tried nano-light since a long ago and I have these weird colors in the mode-line

The colors for mode-line

And for mode-line-inactive

In the code everything looks right, but I don't know if I missed something

https://github.com/rougier/nano-theme/blob/9d64dc167883835a6dc3a6d286c98dbbf7e95a96/nano-theme-support.el#L692-L696

Thanks.

maikol-solis commented 9 months ago

And nano-dark work as expected

rougier commented 9 months ago

I think the theme is missing the mode-line-active that is a new face (I think). Can you check what's the face for mode-line-active (if it exists on your version) ?

maikol-solis commented 9 months ago

Yes, mode-line-active inherits the face from mode-line.

maikol-solis commented 9 months ago

Using custom-set-faces I added these two configs

 `(mode-line :inherit nano-subtle
    :background nil
    :foreground nil
    :box (:color ,nano-light-faded :style nil))
  `(mode-line-inactive
    :inherit nano-subtle-i
    :foreground nil
    :background nil
    :box nil)

An now the active mode-line looks like this

And the inactive one like this

It should be abstracted into the nano-theme structure, but I, personally, think it looks better.

WDYT?

rougier commented 9 months ago

I looks nice! ActuallyI've tested the box in active mode before removing it because I found it a bit ditractng. A for the inactive mode, it's a bit too washed out.

maikol-solis commented 9 months ago

Yes. You certainly have a better judgement about this than I do, and my initial idea could be improved, of course. If you have a better config, I can help you to test it.

rougier commented 9 months ago

I'm actually using the box with nano-vertico mode (to show this is an input area). I get inspired by nyxt.

maikol-solis commented 9 months ago

OK. I installed nano-vertico, and it improves a lot the whole UI. However, it has a similar issue with nano-dark

nano-vertico with the light theme works as expected

rougier commented 8 months ago

Can you open an issue on nano-vertico?

maikol-solis commented 8 months ago

Yes sure, no problem.

dwla commented 4 months ago

maikol-solis’s config of mode-line and mode-line-inactive is intuitive. I find the box (as well as the darker background) in the minibuffer a little bit noisy, it’s more comfortable for me to make mode-line the same as the mode-line-inactive. Here is my config. BTW, nano-theme works well with doom-modeline!!!

(use-package nano-theme
  :custom-face
  (mode-line-buffer-id ((t (:foreground "black" :weight bold))))
  (mode-line-emphasis ((t (:foreground "black" :weight bold))))
  (doom-modeline-buffer-modified ((t (:foreground "black" :weight bold))))
  (doom-modeline-project-dir ((t (:foreground "black" :weight bold))))
  ;; mode-line coincides with mode-line-inactive
  (mode-line ((t (:background "#90A4AE" :foreground "#FFFFFF" :box (:line-width (3 . 3) :color "#90A4AE")))))
  (nano-popout ((t (:foreground "#B22222" :weight bold))))
  (nano-salient ((t (:foreground "#1E90FF" :weight semibold))))
  (vertical-border ((t (:foreground "black"))))
  ;; config for ess
  (doom-modeline-urgent ((t (:foreground "black" :weight bold))))
  (doom-modeline-warning ((t (:foreground "black" :weight bold))))
  (doom-modeline-info ((t (:foreground "black" :weight bold))))
  ;; config for eshell
  (eshell-prompt ((t (:foreground "#B03060"))))
  (dired-flagged ((t (:foreground "#FF3030" :weight bold))))
  :config
  (load-theme 'nano-light t))

rougier / nano-theme

Weird mode-line colors with nano-light #51