search

rougier / nano-theme

GNU Emacs / N Λ N O Theme
GNU General Public License v3.0
358 stars 35 forks source link

Helm colours #7

Open jdtonkin opened 3 years ago

jdtonkin commented 3 years ago

Love this theme, thanks! Any chance of helm being added to the set of colours, please?

rougier commented 3 years ago

I'm not using helm my self so it might be difficult to add them. But if you want to make a PR that would be great. I think part of the work has been done here: https://github.com/rougier/nano-emacs/blob/master/nano-theme.el#L686

It's only a matter of translating syntax. And since I now use a regular theme, we can directly define helm faces.

dangom commented 2 years ago

Here's a potential solution (I use light-mode, so you may have to adapt if using dark mode):

(with-eval-after-load 'helm
    (set-face-attribute 'helm-selection nil :inherit 'nano-face-subtle :background nano-light-subtle :extend t)
    (set-face-attribute 'helm-match nil :inherit 'nano-strong :foreground nano-light-salient :distant-foreground nano-dark-background)
    (set-face-attribute 'helm-source-header nil :inherit  'nano-face-salient       :background nano-light-background)
    (set-face-attribute 'helm-visible-mark nil :inherit 'nano-face-strong))
rougier commented 2 years ago

@dangom Thanks. To be dark/light agnostic, you can use something line (face-background 'nano-default)