search

rougier / scientific-visualization-book

An open access book on scientific visualization using python and matplotlib
https://www.labri.fr/perso/nrougier/
Other
10.16k stars 971 forks source link

Bad links in Appendix B Quick References #18

Open StefRe opened 2 years ago

StefRe commented 2 years ago

While the links are OK in the original cheat sheet https://github.com/rougier/scientific-visualization-book/blob/master/figures/cheatsheets/cheatsheets.pdf, they get corrupted in the individual sheet 1 https://github.com/rougier/scientific-visualization-book/blob/master/figures/cheatsheets/cheatsheets-1.pdf and hence in the book: grafik

(this may or may not be linked to switch to Font Awesome for icons and brand logos).

rougier commented 2 years ago

Oh thanks. Could you make a PR (else I can correct myself)?

StefRe commented 2 years ago

I tried but I have only very basic knowledge of tex and didn't succeed. So I'm afraid I won't be of any help here.

rougier commented 2 years ago

Oh wait, you're right. I directly included the PDF cheatsheets and this would require to change the PDF inside the book repo. I'll let this issue open until next edition (since matplotlib cheatsheets are continuously modified).

StefRe commented 2 years ago

Hm, I'm not sure: as I wrote above, the big cheatsheet is fine, no need to change it for this reason. The issue comes from including the trimmed graphics when splitting it into several pages: https://github.com/rougier/scientific-visualization-book/blob/e131b436923190d1381d0711b24e1ab7af2741e5/figures/cheatsheets/cheatsheets-1.tex#L5

I read a bit about it and tried it with adjustbox as suggested on tex.stackexchange but with the same result (I'm completely new to tex).

rougier commented 2 years ago

Could you try the PDF version included in the pdf repository in this repo to check if you got the same problem?

StefRe commented 2 years ago

I did use the PDF version included in this repo, see links in the original post above.

I also checked out matplotlib/cheatsheets@2e1d87bd3d03 which included png graphic icons instead of fontawsome icons and tried it with this pdf: same result (so I stroke through my assumption above).

rougier commented 2 years ago

For me, links seemed to be correct. Weird.

StefRe commented 2 years ago

Sorry, maybe I didn't express myself unambiguously: the links in the complete cheat sheet work, but after splitting them into individual pages and hence in the book (page 236) they are corrupted (I change the title of this issue to make it clearer).

Do the links in the book indeed work for you?

rougier commented 2 years ago

Yes, I was talking about book links. But I think I've read somewhere (stack overflow ?) that when you include PDF inside latex, links are no preserved and I wonder how I end up with working links.