search

rougier / svg-lib

Emacs SVG libraries for creatings tags, icons and bars
GNU General Public License v3.0
343 stars 31 forks source link

[refactor] Use `when` and `unless` instead of `if` when possible #13

Closed aruZeta closed 2 years ago

aruZeta commented 2 years ago

Just some minor refactor for better readability.

Use when when there is no else part in an if.

When the above is applied, use unless if you have a (when (not cond) (stuff)) which would look (unless cond (stuff)).

Also removing unnecessary if and aligning the else part of an if.

rougier commented 2 years ago

Thanks. Could you sign the Emacs Copyright assignment such that I can merge your fix (after rebase)?

aruZeta commented 2 years ago

First time doing this, so I have to send a mail to emacs-devel@gnu.org to sign it or how?

rougier commented 2 years ago

Yes, see for example here: https://lists.gnu.org/archive/html/emacs-devel/2021-12/msg00806.html

aruZeta commented 2 years ago

Forgot to update you, I sent the signed pdf form like 2 weeks ago (it took some time to get the response), yet still waiting for them to sign it too.

rougier commented 2 years ago

Any news since? Also, you 'll need to rebase your PR I think.

aruZeta commented 2 years ago

"Nicolas P. Rougier" @.***> writes:

Any news since? Also, you 'll need to rebase your PR I think.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

Still no news ... When the process finishes I will do the rebase

-- Alberto (a.k.a. aru)

rougier commented 2 years ago

Still no news ? That's quite an unusual long time. You may have to ask again.

rougier commented 2 years ago

Sorry, wrong button.

aruZeta commented 2 years ago

Yep, no news, I will send the email again.

aruZeta commented 2 years ago

Finally received the email. Checking the conflicts so you can merge.

aruZeta commented 2 years ago

There it goes.

rougier commented 2 years ago

At last! Thanks!