Silence byte compilation warnings

rougier / svg-lib

Emacs SVG libraries for creatings tags, icons and bars

GNU General Public License v3.0

335 stars 30 forks source link

Silence byte compilation warnings #16

Closed fnurkla closed 1 year ago

fnurkla commented 2 years ago

These changes silence a couple of byte compilation warnings, namely:

that the pi variable has been obsolete since Emacs 23, and
that the lexical variable value is unused.

For the first warning pi is changed to float-pi and for the second value is changed to _value to indicate to the compiler that its supposed to be unused.

rougier commented 2 years ago

Thanks. Can you sign the Emacs copyright assignment? (If you don't intend to propose further PR it is not strictly necessary)

fnurkla commented 2 years ago

Will do. I have applied for assignment now.

rougier commented 2 years ago

Cool. Did you get confirmation?

dr-scsi commented 1 year ago

@rougier - Would you consider installing the suggested changes without the copyright assignment? I think the changes are small enough so you could go the copyright-paperwork-exempt-route. TIA.

rougier commented 1 year ago

Just add the fixed manually since there was a conflict.