VSCode icons support

[grolongo]

Hello, would it be possible for svg-lib to add support for VSCode icons?
They use Creative Commons Attribution 4.0 International for their license and their repository is here:
https://github.com/microsoft/vscode-icons

[rougier]

I think it might be possible. Note that you can modify the list of repositories such as to include it. Did you already made some experiments with them?

[grolongo]

So those icons are included with company and they work pretty well, but I didn't try to use them from your package directly.
I'll do that with the examples from your demo and report back.

[grolongo]

So I tested after adding:

(add-to-list 'svg-lib-icon-collections '("vscode-light" . "https://raw.githubusercontent.com/microsoft/vscode-icons/main/icons/light/%s.svg"))
(add-to-list 'svg-lib-icon-collections '("vscode-dark" . "https://raw.githubusercontent.com/microsoft/vscode-icons/main/icons/dark/%s.svg"))

Thing is vscode icons have 2 versions, light and dark, but I fail to see the difference when used with svg-lib, so I'm not sure if the two sources are necessary. Anyway here is the few test results, not sure if that's enough testing to be included in your package. Let me know.

[rougier]

dark / light does not really mater since svg-lib will replace colors. If you want to use dark or light, you can define a style to be used with the icon.

[grolongo]

Indeed:

So can we add

("vscode-light" .
     "https://raw.githubusercontent.com/microsoft/vscode-icons/main/icons/light/%s.svg")

to svg-lib-icon-collections?

[rougier]

Yes. Maybe with the name vscode sinstead of vscode-light. Do you want to make a PR?

[grolongo]

I'm closing the issue.