Fix string/array nil issue on windows

rougier / svg-lib

Emacs SVG libraries for creatings tags, icons and bars

GNU General Public License v3.0

335 stars 30 forks source link

Closed chenyanming closed 3 years ago

chenyanming commented 3 years ago

This fixes the svg-lib-button/svg-lib-progress can not be used on windows. Mentioned on issue #2.

rougier commented 3 years ago

Thanks. Does that mean that the caching is disabled and we need to download the file each time ?

chenyanming commented 3 years ago

I see, that may need more commits.

chenyanming commented 3 years ago

The new commit would check has cache or not.

If not cahced, call url-retrieve-synchronously. If cached, call url-fetch-from-cache.

After I tested, it works both on windows and macOS.

The original design that uses url-insert-buffer-contents has no effect in windows, and it is redundant as well.

Please review.

rougier commented 3 years ago

Looks good to me, thanks.