search

rougier / svg-lib

Emacs SVG libraries for creatings tags, icons and bars
GNU General Public License v3.0
343 stars 31 forks source link

Is there a reason for hard coded scale? #6

Closed HyunggyuJang closed 3 years ago

HyunggyuJang commented 3 years ago

This package is truly marvelous. I love all your packages, especially nano emacs, and elegant emacs' concepts.

And thinking this package adds beautiful fragments without interfering with emacs' default looking.

Here comes my curiosity. Why you specified the scale factor from the first place?

Currently, most svg outputs from this library are specified with :scale 1.

It interferes with my purpose, to prettify presentation view, exploiting org tree slide mode.

I'm thinking about applying the idea you showcased at demo org file, to replace todo keywords and tags. And to match images in slides with scaled text — usually by factor of 5 — I'm adjusting image-scaling-factor accordingly. But with hard coded scale, such arrangement has broken.

Hence, if possible, I'd like to remove hard coded scale specifications.

Thanks for this superb package, your work always amazes me.

rougier commented 3 years ago

I don't think there's a specific reason (but I'm not sure) and it can probably be changed. What would be the best in your case ? An extra parameter indicating the actual global scale ?

HyunggyuJang commented 3 years ago

Thanks for your quick response!

Just removing :scale 1 at the end of each image making functions would do the job!

As svg-image calls create-image under the hood, and in turn, which respects image-scaling-factor’s value.

Thus, changing from 

(svg-image svg :scale 1 :ascent 'center)

to 

(svg-image svg :ascent 'center)

suits my need!

If you like, I can make pull request for it.

rougier commented 3 years ago

PR sounds good. I may need to first check in issue if it was introduced following an unexpected issue. Maybe this will solve the long standing issue we have we font size (depending on logical vs actual screen resolution).

rougier commented 3 years ago

Ok, I conform there were no exact reason: https://github.com/rougier/svg-tag-mode/commit/a34a2e1128fa99f999c34c3bc6642fb62b887f34#diff-f67c859c1d4ebde5daad417b28f9bfee9496550b0bc39333fe92b05abc566cf2

HyunggyuJang commented 3 years ago

@rougier, I can confirm this little change actually works for me.

Thanks for your elaboration!!

rougier commented 3 years ago

Merged! Thanks.