search

rougier / svg-tag-mode

A minor mode for Emacs that replace keywords with nice SVG labels
GNU General Public License v3.0
488 stars 28 forks source link

Introduce tag font face #32

Open DivineDominion opened 2 years ago

DivineDominion commented 2 years ago

Somewhat related to #5, what do you think about defining a svg-tag-face that inherits from :default but allows users to customize if needed?

Am asking because with my default font setting, the tags are a bit on the larger side:

image

Would like to make them 80% height or so. And my main font is monospaced, but for tags I'd prefer variable width.

(If there are no objections I can also try to add that myself and propose a PR)

rougier commented 2 years ago

You should be able to specify a different face with :face . Do you mean it is not working?

DivineDominion commented 2 years ago

@rougier I was thinking of changing the default in https://github.com/rougier/svg-tag-mode/blob/main/svg-tag-mode.el#L165-L166 to svg-tag-face to globally change all tags, instead of having to adjust each call to svg-tag-make and similar. So not a bug report, just an idea for convenience

rougier commented 2 years ago

Like a svg-tag-mode-default-face?

DivineDominion commented 2 years ago

@rougier Yeah, something like that! (Not sure about naming conventions so I cannot suggest anything here with confidence :))

rougier commented 2 years ago

Done (svg-tag-default-face) ?