search

roundcube / roundcubemail-docker

Resources to build Docker images for Roundcube Webmail
293 stars 129 forks source link

Better defaults for smtp settings #24

Closed thomascube closed 6 years ago

thomascube commented 6 years ago

The default config for docker images should contain the following options:

$config['smtp_user'] = '%u';
$config['smtp_pass'] = '%p';

This should cover the most usual case. Cloned from https://github.com/roundcube/roundcubemail/issues/6332

aspettl commented 6 years ago

On Roundcube master this is fixed by https://github.com/roundcube/roundcubemail/commit/7fc626d52713963f57b56a128bd0f95070d40613 - however, it seems that this commit is not part of Roundcube 1.3.x. So this means that if we want to fix this now for the Docker image, we would need to change the config file that is generated in docker-entrypoint.sh.

Do we want to do that or do we simply wait until the changed default values from Roundcube are part of a release?

thomascube commented 6 years ago

That's exactly what we want to do. Although the config created in docker-entrypoint.sh shall remain as simple as possible, it's supposed to deliver defaults one might expect in a Docker setup.