search

roundcube / roundcubemail-docker

Resources to build Docker images for Roundcube Webmail
291 stars 129 forks source link

Become an "Official Image" #31

Open J0WI opened 6 years ago

J0WI commented 6 years ago

(from https://github.com/roundcube/roundcubemail/issues/5827)

It would be great if you could do the steps to get into Dockers standard library aka "Official Images".

There are some administrative steps to fulfill: https://github.com/docker-library/official-images#contributing-to-the-standard-library

This will enhance maintenance and trust in this Docker image.

ytzelf commented 5 years ago

I reckon for a project with the kind of audience RC has you deserve to become a certified image and keep the images up-to-date with the releases.

J0WI commented 4 years ago

@thomascube is this something you support? If so, a PR to https://github.com/docker-library/docs and https://github.com/docker-library/official-images is required to request inclusion. See also https://github.com/docker-library/official-images/blob/master/NEW-IMAGE-CHECKLIST.md

thomascube commented 4 years ago

In general yes. But I'm lacking the time to work through all the requirements and best-practices in order to get there. I don't think our current setup already satisfies all the requirements for becoming official. Any support or advise on this topic is highly welcome.

J0WI commented 4 years ago

I think this is already in a good shape. There are pending PRs to allow updates of existing volumes (#65) and to simplify the maintenance of this repo (#55). Requesting inclusion will give us further feedback.

williamdes commented 2 years ago

Is there some tasks to be done @J0WI ?

J0WI commented 2 years ago

One of the maintainers need to open a MR at https://github.com/docker-library/official-images

williamdes commented 2 years ago

One of the maintainers need to open a MR at https://github.com/docker-library/official-images

@thomascube would you mind doing this ? @J0WI could you give the steps needed for the content of the MR ?

J0WI commented 2 years ago

Here is a checklist: https://github.com/docker-library/official-images/blob/master/NEW-IMAGE-CHECKLIST.md

I'd recommend to create something like a generate-stackbrew-library.sh to create the library file from a script.

thomascube commented 2 years ago

@J0WI @williamdes There's quite a list of things to do in terms of documentation and I'm currently lacking the time to get through all of that. Is becoming official really the only way to get ARM builds up?

J0WI commented 2 years ago

You already have most of the required documentation in your README. Though there is some work left to match the format and style of the library.

You can also cross build Docker images using buildx and QEMU: https://github.com/marketplace/actions/docker-setup-qemu But only images from the official library defaults to the correct architecture on each platform, so users have to change the tag or repo manually.

williamdes commented 1 year ago

@J0WI @williamdes There's quite a list of things to do in terms of documentation and I'm currently lacking the time to get through all of that. Is becoming official really the only way to get ARM builds up?

See #201

williamdes commented 1 year ago

@J0WI @williamdes There's quite a list of things to do in terms of documentation and I'm currently lacking the time to get through all of that. Is becoming official really the only way to get ARM builds up?

201 is merged and deployed to the hub, we are now multi arch 🎉