search

roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.74k stars 1.62k forks source link

Ticket #1484422 still occurs in SVN trunk rev 630 #1112

Closed rcubetrac closed 16 years ago

rcubetrac commented 17 years ago

Reported by andryan on 29 Jun 2007 08:50 UTC as Trac ticket #1484460

Reply/forwarding emails still shows empty subject (except for the "Re: " part), as well as empty original sender's information under "Original Message". Here's the message source:

Return-Path: <andryan@blah.com>
X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on tiara
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=7.5 tests=none autolearn=ham
    version=3.1.9
Delivered-To: blah.net-andryan@blah.net
Received: (qmail 2462 invoked by uid 507); 29 Jun 2007 08:34:44 -0000
DomainKey-Status: good        
Received: from 255.255.255.255 by tiara (envelope-from <andryan@blah.com>, uid 89) with qmail-scanner-2.01 
 (clamdscan: 0.90.2/3551.  
 Clear:RC:0(255.255.255.255):. 
 Processed in 0.019942 secs); 29 Jun 2007 08:34:44 -0000
Received: from unknown (HELO blah.com) (255.255.255.255)
  by mx.mail.blah.net with SMTP; 29 Jun 2007 08:34:44 -0000
Received: by blah.com with SMTP id k17so1258651waf
        for <andryan@blah.net>; Fri, 29 Jun 2007 01:34:41 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed;
        d=blah.com; s=beta;
        h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=n6QS5d/mxB+8fuBvjHsDV717sjYVj+eEPM9wElDEiROkRsS6a9gqoRvtdto0NKrIL0+I7G0lJBqs8WgThKicahZLyHvJF42B9pm8Kc6ihDBqx7mTZWk/A3y7C/Oco0s9NkwFjBaSiDOdbUrWlyvVPNbfbhj6jNP/Z7QV9lqGuYE=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=blah.com; s=beta;
        h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=UBOgnsF1rjUutNP968LGb7LL2uyltzOqmLFR5bf7w8Zf751WfxqkRm2RLMhL97HqvVAMs1d2BOP467Z2rAZlBYsOI7BRyu2o7QafWdp/bHmGWhkRV0rxBZFROQKII3SPOTEfkZgaXzA0eZZ5Zx/dNyWHFe1nRg+jCIttuhO9WK0=
Received: by 255.255.255.255 with SMTP id v16mr2364332wal.1183106081279;
        Fri, 29 Jun 2007 01:34:41 -0700 (PDT)
Received: by 255.255.255.255 with HTTP; Fri, 29 Jun 2007 01:34:41 -0700 (PDT)
Message-ID: <853cf73c0706290134x204a065dw7634a398fc371ac3@mail.blah.com>
Date: Fri, 29 Jun 2007 15:34:41 +0700
From: Andryan <andryan@blah.com>
To: andryan@blah.net
Subject: tes
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Migrated-From: http://trac.roundcube.net/ticket/1484460

rcubetrac commented 17 years ago

Severity changed by @thomascube on 10 Aug 2007 13:19 UTC

major => minor

rcubetrac commented 17 years ago

Milestone changed by @thomascube on 10 Aug 2007 13:19 UTC

=> 0.1-stable

rcubetrac commented 17 years ago

Comment by andryan on 21 Aug 2007 17:44 UTC

I'm using SVN 698 and this issue has been fixed. Please close this ticket (and probably #1484422 too).

rcubetrac commented 16 years ago

Comment by @thomascube on 10 Sep 2007 07:43 UTC

Fixed according to andryan

rcubetrac commented 16 years ago

Status changed by @thomascube on 10 Sep 2007 07:43 UTC

new => closed

rcubetrac commented 16 years ago

Milestone changed by @thomascube on 10 Sep 2007 07:46 UTC

0.1-stable => 0.1-rc2

rcubetrac commented 16 years ago

Comment by andryan on 11 Sep 2007 05:29 UTC

Err, this is weird. Now it's broken again. I have updated to rev 790 and reverted back to rev 698 but still broken.

rcubetrac commented 16 years ago

Status changed by andryan on 11 Sep 2007 05:29 UTC

closed => reopened

rcubetrac commented 16 years ago

Comment by @thomascube on 11 Sep 2007 09:36 UTC

Cannot reproduce with your sample message. Can anyone else confirm this bug?

rcubetrac commented 16 years ago

Comment by andryan on 11 Sep 2007 11:13 UTC

This applies when replying to both html and text emails.

rcubetrac commented 16 years ago

Comment by andryan on 11 Sep 2007 11:17 UTC

Return-Path: <andryan@blah.com>
X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on tiara
X-Spam-Level: 
X-Spam-Status: No, score=-1.3 required=7.5 tests=AWL,BAYES_00 autolearn=ham
    version=3.1.9
Delivered-To: blah.net-andryan@blah.net
Received: (qmail 1446 invoked by uid 507); 11 Sep 2007 05:27:49 -0000
DomainKey-Status: good        
Received: from 66.249.82.231 by tiara (envelope-from <andryan@blah.com>, uid 89) with qmail-scanner-2.01 
 (clamdscan: 0.90.3/4226.  
 Clear:RC:0(66.249.82.231):. 
 Processed in 0.019858 secs); 11 Sep 2007 05:27:49 -0000
Received: from unknown (HELO wx-out-0506.blah.com) (66.249.82.231)
  by mail.blah.net with SMTP; 11 Sep 2007 05:27:49 -0000
Received: by wx-out-0506.blah.com with SMTP id t11so1398679wxc
        for <andryan@blah.net>; Mon, 10 Sep 2007 22:27:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=blah.com; s=beta;
        h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        bh=QIbV4Cc9SPJYhStCKqEYkBnrucoH7okk/IaU+x6Kpv0=;
        b=nFrbyT0ENUSf13HM8Zjf3ibGcdoCv7umOdXeitsBLBrTv5rbaZQHzP05SDRpSmNUBDb6aWOewDsY1+y8cldJaEcJbz7lnXIkXmYgexaIyuK2ZIXOaWhjTtlCQRDalCWQSVV43We0+cKpvYf6IxKOtRPYTMiRqjZUPIKxdA3N5e0=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=blah.com; s=beta;
        h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=XZ8rcnT2AcX3Qc/y+sPZJw4iDs0kX2cjjfCeG70aJeoZJ8HxhbNHCFdk0es9PK5f/NqpgIelATatA1g8fV644PRfdTfT3gq63UdC6ICfa67Oj2yx3JBls6TCC2KmAJ/e4uHt9lBTm1VZkLNVkF70dAIz8puAvX8O9T6ZVy+rdwg=
Received: by 10.90.93.6 with SMTP id q6mr4803064agb.1189488469831;
        Mon, 10 Sep 2007 22:27:49 -0700 (PDT)
Received: by 10.90.93.15 with HTTP; Mon, 10 Sep 2007 22:27:49 -0700 (PDT)
Message-ID: <853cf73c0709102227w4d2d969fv8ea5827f672b124d@mail.blah.com>
Date: Tue, 11 Sep 2007 12:27:49 +0700
From: Andryan <andryan@blah.com>
To: andryan@blah.net
Subject: asd
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

asd
rcubetrac commented 16 years ago

Comment by @thomascube on 11 Sep 2007 17:03 UTC

Again, this sample works for me...

rcubetrac commented 16 years ago

Comment by jpingle on 11 Sep 2007 18:00 UTC

Going out on a limb here since it seems hard to reproduce:

Do you have message caching enabled? If so, have you tried with this disabled? It seems if it works sometimes and not others, and the messages on the server are not changing, then it could be getting parsed incorrectly going into or coming out of the cache?

Also, instead of copy/paste, is there a way you can get the actual file off the server and upload it to http://testing.roundcube.net/ - and then post the ID back here in the ticket. It could be a problem that isn't present after you copy/paste the message source.

rcubetrac commented 16 years ago

Comment by andryan on 13 Sep 2007 13:54 UTC

Upload ID 20070913_155252_3 I have message caching disabled. Do you want me to upload php.ini and phpinfo output as well?

rcubetrac commented 16 years ago

Comment by andryan on 14 Sep 2007 01:43 UTC

BTW, the current SVN version of vnext branch doesn't have this problem.

rcubetrac commented 16 years ago

Comment by andrex on 25 Sep 2007 23:24 UTC

I also have this problem, with version 0.1 rc1. My IMAP server is bincimap, running on Debian.

rcubetrac commented 16 years ago

Comment by andrex on 27 Sep 2007 09:46 UTC

Followup: I ran the same roundcube client against a dovecot server (on another host), and the bug did not occur.

rcubetrac commented 16 years ago

Comment by @thomascube on 13 Oct 2007 12:41 UTC

This seems to be a IMAP server dependent problem. We have to find out what's the difference between fetching the header for view and fetching them when replying. Actually there shouldn't be any...

rcubetrac commented 16 years ago

Milestone changed by @thomascube on 13 Oct 2007 12:41 UTC

0.1-rc2 => 0.1-stable

rcubetrac commented 16 years ago

Comment by eyran on 21 Oct 2007 07:56 UTC

I had a go at this. The patch below fixed it for me, but I haven't tested it against any other IMAP servers.

--- program/lib/imap.inc        (revision 860)
+++ program/lib/imap.inc        (working copy)
@@ -1261,15 +1261,14 @@
                        $lines = array();
                        do{
                                $line = chop(iil_ReadLine($fp, 300),"\r\n");
+                               if (!$line) break;
                                if (ord($line[$lines[$i](0])<=32)).=(empty($lines[                               else{
                                        $i++;
                                        $lines[$i]($i])?"":"\n").trim(chop($line));
) = trim(chop($line));
                                }
-                       }while($line[&& strncmp($line, $key, strlen($key)));  // patch from "Maksim Rubis" <siburny@hotmail.com>
+                       }while($line[0](0]!=")")!=")");

-            if(strncmp($line, $key, strlen($key)))
-            { 
                        //process header, fill iilBasicHeader obj.
                        //      initialize
                        if (is_array($headers)){
@@ -1303,13 +1302,6 @@
                                $result[= $regs[1]($id]->charset);

                        $messageID = $headers[                      if (!$messageID) "mid:".$id;
-                       $result[$id]("message-id"];
-)->messageID = $messageID;
-                       }
-            else {
-            $a=explode(" ", $line);
-            } 
-                       
                }
        }while(strcmp($a[0], $key)!=0);
rcubetrac commented 16 years ago

Comment by Alfafa on 31 Oct 2007 17:26 UTC

Hi

I also experience this bug (and also the empty recipient bug)

Also with bincimap. It makes roundcube quite unuseable.

Regards Hasse

rcubetrac commented 16 years ago

Comment by Alfafa on 31 Oct 2007 18:19 UTC

Hi

Just tried with this patch(It couldn't apply cleanly with rc2). I edited the imap.inc file myself...and it works. Now I also get the recipients in the preview pane. That didn't work before either

This is the patch I used: --- program/lib/imap.inc 2007-07-03 19:37:20.000000000 +0200 +++ program/lib/imap.inc 2007-10-31 18:33:32.000000000 +0100 @@ -1261,15 +1261,14 @@ $lines = array(); do{ $line = chop(iil_ReadLine($fp, 300),"\r\n");

- }

    }
}while(strcmp($a[0], $key)!=0);
rcubetrac commented 16 years ago

Comment by andryan on 12 Jan 2008 14:04 UTC

I'm currently at SVN 954. It seems to be fixed partially, however there's a problem. If the "From" line is the last header, then I see something like "UID ...)" appended to the sender name when viewing email. Can someone test this by sending an email to support@mikrotik.com or any OTRS (Open Ticket Request System) system? The inbox list shows the correct sender though (without "UID ...)").

rcubetrac commented 16 years ago

Comment by @till on 2 Feb 2008 02:46 UTC

@andryan: Can you tell me if this is still "open"?

rcubetrac commented 16 years ago

Comment by @till on 11 Feb 2008 17:46 UTC

Sent email to support@mikrotik.com.

rcubetrac commented 16 years ago

Comment by @till on 11 Feb 2008 18:09 UTC

I got a response from your OTRS and I just noticed that (your) OTRS is not UFT-8 compatible and screwed up my last name's Umlaut. Where do I see this UID thing?

rcubetrac commented 16 years ago

Owner changed by @till on 11 Feb 2008 18:21 UTC

=> till

rcubetrac commented 16 years ago

Status changed by @till on 11 Feb 2008 18:21 UTC

reopened => new

rcubetrac commented 16 years ago

Comment by @till on 11 Feb 2008 22:21 UTC

Closing this ticket - I managed to "inject" the example provided into my mailbox and it works just fine. Subject is set in Reply and Forward.

If you need to re-open, supply an example and either upload to testing or paste it here in and!

rcubetrac commented 16 years ago

Status changed by @till on 11 Feb 2008 22:21 UTC

new => closed