Patch for iPhone use

[rcubetrac]

Reported by chasd on 27 Nov 2007 20:29 UTC as Trac ticket #1484680

Attached zip file include svn diff from r932 SVN and three new PNG files for an "Open message" button. This is to allow iPhone ( or iPod Touch ) access to RoundCube, where a double-click will not open a message. One line added to the en_US labels file for the button, and one line added to the mail template file of the default skin.

Keywords: iPhone Migrated-From: http://trac.roundcube.net/ticket/1484680

[rcubetrac]

Comment by seansan on 19 Feb 2008 20:32 UTC

Review in 0.1.5

[rcubetrac]

Milestone changed by seansan on 19 Feb 2008 20:32 UTC

=> 0.1.5

[rcubetrac]

Milestone changed by @thomascube on 9 Mar 2008 16:40 UTC

0.1.5 => later

[rcubetrac]

Comment by anybody on 29 Aug 2009 19:59 UTC

Is there any progress on this?

I've noticed that in 0.3rc1 the Roundcube interface is still totally unusable on the iPhone due to minor problems...

Very sad that the best mobile browser isn't supported :-(

[rcubetrac]

Comment by trisk on 24 Jan 2010 18:49 UTC

The Opera Mini 5 mobile browser also has problems opening messages because double-clicking is not supported. I'm not convinced adding a button which takes up valuable screen space is the best solution, though.

[rcubetrac]

Comment by damoxc on 31 Mar 2010 15:36 UTC

I've made a patch that changes the event from dblclick to just a click, since you can't really select a message.

This could be improved (I'll probably do this later on this evening) so it adds a is_mobile_device() so scripts can check and adjust behavior accordingly, and of course include support for more than just the iPhone (Blackberry, Opera Mini etc)

[rcubetrac]

Comment by @alecpl on 18 Feb 2011 19:09 UTC

Could someone check this with current version? I see some code for iphone/ipad touch-related.

[rcubetrac]

Comment by @alecpl on 31 May 2011 10:25 UTC

Just thinking, maybe we could add this button and hide it on non-mobile browsers using css (that should be possible).

[rcubetrac]

Comment by Nikita on 31 May 2011 10:59 UTC

With these changes we worked very well [roundcubemail/program/localization/en_US/labels.inc

--- roundcubemail/program/localization/en_US/labels.inc (revision 932) +++ roundcubemail/program/localization/en_US/labels.inc (working copy) @@ -102,6 +102,7 @@ // toolbar buttons $labels['checkmail']([br]]

Index:)        = 'Check for new messages';
 $labels[ = 'Create a new message';
+$labels['openmessage']('writenewmessage'])  = 'Open message';
 $labels[  = 'Reply to the message';
 $labels['replytoallmessage']('replytomessage']) = 'Reply to sender and all recipients';
 $labels['forwardmessage']   = 'Forward the message';
Index: roundcubemail/skins/default/templates/mail.html
===================================================================
--- roundcubemail/skins/default/templates/mail.html 
+++ roundcubemail/skins/default/templates/mail.html (working copy)
@@ -112,6 +112,7 @@
<div id="messagetoolbar">
<roundcube:button command="checkmail" type="link" class="button checkmail" classAct="button checkmail" classSel="button checkmailSel" title="checkmail" content=" " />
<roundcube:button command="compose" type="link" class="button compose" classAct="button compose" classSel="button composeSel" title="writenewmessage" content=" " />
+<roundcube:button command="show"  type="link" class="buttonPas show"  classAct="button show" classSel="button showSel" title="openmessage"  content=" " />
<roundcube:button command="reply" type="link" class="buttonPas reply" classAct="button reply" classSel="button replySel" title="replytomessage" content=" " />
<span class="dropbutton">
<roundcube:button command="reply-all" type="link" class="buttonPas replyAll" classAct="button replyAll" classSel="button replyAllSel" title="replytoallmessage" content=" " />

===================================================================
--- roundcubemail/skins/default/mail.css    
+++ roundcubemail/skins/default/mail.css    (working copy)
@@ -142,6 +142,7 @@
#messagetoolbar a.sendSel {
  background-position: -416px -32px;
}

+#messagetoolbar a.show {
+  background-position: -416px 0;
+}
+
+#messagetoolbar a.showSel {
+   background-position: -416px -32px;
+}

#messagetoolbar select.mboxlist
{

greetings Barbara Vergara www.fecyl.com

[rcubetrac]

Comment by Kepi on 16 Sep 2012 14:30 UTC

Hi, we just run into this issue with recent version (0.8.1).

Mobile browsers and especially tablets become more and more common and our users were unhappy that they can't use it there.

I just modified damoxc's patch with detection of common mobile browser. It simply works out of the box. If you are on mobile/tablet it use singleclick for opening mail, on desktop dblclick still works as before.

It will be great to include this patch in next version.

[rcubetrac]

Comment by @thomascube on 17 Sep 2012 17:22 UTC

Double-tip to open a message works for me on iPads. Even drag&drop can be done on touch devices. Support for that was added in r3682/subversion. See also #1488558

[rcubetrac]

Comment by Kepi on 1 Oct 2012 23:33 UTC

Ok, I can see that my approach was wrong because it disabled single click actions (i.e. flag message).

Unfortunately there is still problem on android tablets - simply doubleclick just resize screen and don't do anything special. Same with drag&drop. I tried to add android detection and modify changes you mentioned in r3682/subversion but didn't work.

[rcubetrac]

Comment by @thomascube on 2 Sep 2013 19:30 UTC

This patch seems obsolete after the recent optimizations for touch devices in 0.9.3

[rcubetrac]

Status changed by @thomascube on 2 Sep 2013 19:30 UTC

new => closed