roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.79k stars 1.62k forks source link

Broken attach file name #1871

Closed rcubetrac closed 15 years ago

rcubetrac commented 15 years ago

Reported by joungkyun on 6 Oct 2008 15:13 UTC as Trac ticket #1485468

On SVN trunk revision 1941 or 0.2-beta, attach file name that made with RFC 2231 is broken.

For example, file name encoding with follows,

 filename*0*=UTF-8''%32%30%30%38%30%39%32%36%20%EC%82%AC%EB%AC%B4%EC%8B%A4;
 filename*1*=%2E%6A%70%67

roundcube parsed only filename1 with follow codes

     else if (!empty($part->d_parameters[{
       $i = 0;
       while (isset($part->d_parameters['filename*'.$i.'*']('filename*0*']))))) {
         $i++;
         $filename_encoded .= $part->d_parameters['filename*'.$i.'*'];
       }
       if ($i<2) {
         $headers = iil_C_FetchPartHeader($this->conn, $this->mailbox, $this->_msg_id, $part->mime_id);

So, I attach patch that fix this problem.

Migrated-From: http://trac.roundcube.net/ticket/1485468

rcubetrac commented 15 years ago

Comment by joungkyun on 6 Oct 2008 15:16 UTC

filename of All charset has this problem.

rcubetrac commented 15 years ago

Comment by tensor on 6 Oct 2008 16:02 UTC

Please attach the source of sample message.

rcubetrac commented 15 years ago

Comment by @alecpl on 6 Oct 2008 17:47 UTC

Fixed in 28db73f7.

rcubetrac commented 15 years ago

Status changed by @alecpl on 6 Oct 2008 17:47 UTC

new => closed